[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Introduce two new KCrash methods: void
From:       Thiago Macieira <thiago () kde ! org>
Date:       2009-10-25 21:32:03
Message-ID: 200910252232.04010.thiago () kde ! org
[Download RAW message or body]


Em Domingo 25. Outubro 2009, ās 21.04.53, Chani escreveu:
> On October 25, 2009 11:45:02 Thiago Macieira wrote:
> > Em Domingo 25. Outubro 2009, ās 17.33.09, George Kiagiadakis escreveu:
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > http://reviewboard.kde.org/r/1970/
> > > -----------------------------------------------------------
> > >
> > > Review request for kdelibs.
> > >
> > >
> > > Summary
> > > -------
> > >
> > > This patch introduces two new methods in the KCrash namespace: void
> > >  setLaunchDrKonqi(bool) and bool launchDrKonqi(). The reason for
> >
> > The name "launchDrKonqi" is a bad one. "Launch" is a verb in the
> >  imperative, so "launchDrKonqi" doesn't look like a setter, but an
> > action.
> >
> > I recommend using "launchesDrKonqi" instead.
> >
> > Also, for boolean properties, prefixing the getter with "is" is
> >  recommended, but then you need an adjective as the core of the property
> >  name (as in "isDrKonqiLaunchEnabled"). If you can't come up with a good
> >  name, don't use "is", it's not a problem.
> 
> enableDrKonqui and isDrKonquiEnabled?

No, those don't match property getter/setter naming conventions.

Properties should be nouns, not verbs. What I said above about adjective was 
wrong: the property was still a noun (launch), but was disambiguated from the 
homograph verb by an adjective.

If you call it "enable", it's an action. The opposite is "disable", not a 
true/false parameter.

> hrm, we should probably be replying on reviewboard instead of by mail...
>  darn web things.

I have yet to create an account there...

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]