[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Introduce two new KCrash methods: void
From:       Chani <chanika () gmail ! com>
Date:       2009-10-25 20:04:53
Message-ID: 200910251305.01901.chanika () gmail ! com
[Download RAW message or body]


On October 25, 2009 11:45:02 Thiago Macieira wrote:
> Em Domingo 25. Outubro 2009, ās 17.33.09, George Kiagiadakis escreveu:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1970/
> > -----------------------------------------------------------
> >
> > Review request for kdelibs.
> >
> >
> > Summary
> > -------
> >
> > This patch introduces two new methods in the KCrash namespace: void
> >  setLaunchDrKonqi(bool) and bool launchDrKonqi(). The reason for
> 
> The name "launchDrKonqi" is a bad one. "Launch" is a verb in the
>  imperative, so "launchDrKonqi" doesn't look like a setter, but an action.
> 
> I recommend using "launchesDrKonqi" instead.
> 
> Also, for boolean properties, prefixing the getter with "is" is
>  recommended, but then you need an adjective as the core of the property
>  name (as in "isDrKonqiLaunchEnabled"). If you can't come up with a good
>  name, don't use "is", it's not a problem.
> 

enableDrKonqui and isDrKonquiEnabled?

hrm, we should probably be replying on reviewboard instead of by mail... darn 
web things.

-- 
This message brought to you by eevil bananas and the number 3.
www.chani3.com

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]