[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add thubnail support for Microsoft Windows
From:       "S Page" <info () skierpage ! com>
Date:       2009-10-23 6:51:12
Message-ID: 20091023065112.13978.20983 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1533/#review2779
-----------------------------------------------------------


(I apologize, I've never used this thing before.)

The existing imagethumbnail.desktop file in 4.3.2 already claims the image/x-ico \
MimeType which is an alias for vnd.microsoft.icon.  I found that adding \
vnd.microsoft.icon to this file and restarting KDE makes Dolphin preview favicon.ico \
files, fixing bug 211491 in a much simpler and less invasive way. (But probably not \
handling multiple icons per file and other fancy features.)  Is it OK to split/share \
thumbnailing between two ThumbCreator services?

- S


On 2009-09-08 13:42:30, Pali Rohár wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1533/
> -----------------------------------------------------------
> 
> (Updated 2009-09-08 13:42:30)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch add thubnail support for Microsoft Windows executables (.exe, .dll, \
> .ocx, ...) and images (.ico, .cur, ...) in konqueror/dolphin. 
> It use external applications icoutils from http://www.nongnu.org/icoutils/
> 
> 
> This addresses bug 185348.
> https://bugs.kde.org/show_bug.cgi?id=185348
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagethumbnail.desktop \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.h \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.cpp \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.h \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.cpp \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexethumbnail.desktop \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.cpp \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt 1021172 
> trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1533/diff
> 
> 
> Testing
> -------
> 
> With wine it works fine for me.
> 
> 
> Thanks,
> 
> Pali
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]