[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: break_lines.h:137: warning: suggest parentheses
From:       "Jaroslaw Staniek" <staniek () kde ! org>
Date:       2009-10-21 21:22:14
Message-ID: 20091021212214.495.45058 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1922/#review2752
-----------------------------------------------------------

Ship it!


Ok, but just use: 
if ( (row > 0x2d && row < 0xfb) || row == 0x11 ) {

- Jaroslaw


On 2009-10-21 17:36:01, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1922/
> -----------------------------------------------------------
> 
> (Updated 2009-10-21 17:36:01)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The dashboard
> http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdelibs/khtml/rendering/break_lines.h:137: warning: suggest parentheses around \
> &amp;&amp; within || 
> at
> inline bool isBreakable( const QChar *str, const int pos, int len )
> 
> my proposal: complete with some more parentheses
> see: break_lines-gm-24.diff
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/khtml/rendering/break_lines.h 1038700 
> 
> Diff: http://reviewboard.kde.org/r/1922/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]