[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: kjs_html.cpp:2385: warning: enumeration value
From:       "Guy Maurel" <guy-kde () maurel ! de>
Date:       2009-10-19 16:03:02
Message-ID: 20091019160302.13636.76162 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1896/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdelibs/khtml/ecma/kjs_html.cpp:2385: warning: enumeration value 'T_Coll' not handled in switch
                                                                      'T_ReadOnly' not handled in switch

at
bool KJS::HTMLElement::handleBoundWrite(ExecState* exec, int token, JSValue* value)

my proposal: add the two enumeration value  in the switch
see: kjs_html-gm-18.diff


Diffs
-----

  /trunk/KDE/kdelibs/khtml/ecma/kjs_html.cpp 1037564 

Diff: http://reviewboard.kde.org/r/1896/diff


Testing
-------


Thanks,

Guy


[prev in list] [next in list] [prev in thread] [next in thread]