[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: dialog.cpp:116: warning: suggest parentheses around
From:       "Guy Maurel" <guy-kde () maurel ! de>
Date:       2009-10-19 15:18:13
Message-ID: 20091019151813.12517.98859 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1894/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdelibs/plasma/dialog.cpp:116: warning: suggest parentheses around assignment used as truth value

at
void DialogPrivate::themeChanged()

my proposal: 2 parentheses more
see: dialog-gm-16.diff


Diffs
-----

  /trunk/KDE/kdelibs/plasma/dialog.cpp 1037564 

Diff: http://reviewboard.kde.org/r/1894/diff


Testing
-------


Thanks,

Guy


[prev in list] [next in list] [prev in thread] [next in thread]