From kde-core-devel  Sun Oct 18 14:25:46 2009
From: "Albert Astals Cid" <aacid () kde ! org>
Date: Sun, 18 Oct 2009 14:25:46 +0000
To: kde-core-devel
Subject: Re: Review Request: Allow translations of Qt4 style names
Message-Id: <20091018142546.4317.79549 () localhost>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=125587593218147


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1845/#review2697
-----------------------------------------------------------

Ship it!


Seems ok-ish and should not break anything as far as i can see

- Albert


On 2009-10-15 13:18:46, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1845/
> -----------------------------------------------------------
> 
> (Updated 2009-10-15 13:18:46)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Please check
> * if I didn't mess up the whole i18n stuff
> * if the texts are good for translation
> * if we are allowed to use names such as Apple, Windows, Vista, etc. in descriptions
> * if the bug is worth fixing at all :)
> 
> 
> This addresses bug 152947.
>     https://bugs.kde.org/show_bug.cgi?id=152947
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtwindowsxp.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtplastique.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtwindowsvista.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtcleanlooks.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtgtk.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/qtmacintosh.themerc PRE-CREATION 
>   /trunk/KDE/kdebase/runtime/kstyles/CMakeLists.txt 1035592 
>   /trunk/KDE/kdebase/runtime/kstyles/themes/CMakeLists.txt 1035592 
> 
> Diff: http://reviewboard.kde.org/r/1845/diff
> 
> 
> Testing
> -------
> 
> Builds, installs, and shows the descriptions in my (english) system, instead of the old "No description available" in systemsettings.
> 
> 
> Thanks,
> 
> Christoph
> 
>