[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: xsyncbasedpoller.cpp:242: warning: comparison
From:       "Dario Freddi" <drf54321 () gmail ! com>
Date:       2009-10-17 9:54:11
Message-ID: 20091017095411.2821.73861 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1866/#review2683
-----------------------------------------------------------


It seems to me quite an intrusive patch only to get rid of a warning... I'd just let \
downstream fix this.

- Dario


On 2009-10-16 17:49:31, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1866/
> -----------------------------------------------------------
> 
> (Updated 2009-10-16 17:49:31)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The dashboard
> http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> kutils/kidletime/xsyncbasedpoller.cpp:242: warning: comparison between signed and \
> unsigned integer expressions 
> at
> void XSyncBasedPoller::catchIdleEvent()
> 
> This is a bug within X11/extensions.
> see: xsyncbasedpoller-gm-15.diff
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kutils/kidletime/xsyncbasedpoller.cpp 1033934 
> 
> Diff: http://reviewboard.kde.org/r/1866/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]