[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: fixes a crash I was having web-saving the acid3 test
From:       "Jaime Torres" <jtamate () gmail ! com>
Date:       2009-10-03 10:25:46
Message-ID: 20091003102546.17247.55022 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1763/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Fixes a crash I was having web-saving the acid3 test site. (once passed the test).
Instead of triggering the ASSERT, place a condition to do nothing (as there is \
nothing to do with an empty document).

I hope this is the right group. I have not found any group for extragear nor \
konqueror.


Diffs
-----

  /trunk/extragear/base/konq-plugins/webarchiver/archivedialog.cpp 1030845 

Diff: http://reviewboard.kde.org/r/1763/diff


Testing
-------

The acid3 test site now is archived. When tested the archived page it gives a very \
low score, but that is another story.


Thanks,

Jaime


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic