[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: New KSignalPlotter graph for plotting continuous
From:       "John Tapsell" <johnflux () gmail ! com>
Date:       2009-09-29 8:38:47
Message-ID: 20090929083847.6691.76421 () localhost
[Download RAW message or body]



> On 2009-09-15 07:51:21, Andreas Kling wrote:
> > Let's see..
> > 
> > * The "beam order" related API (addBeam() & co) is a bit awkward. I'd prefer more \
> >                 explicit initialization, something like setBeamColor()
> > * removeBeam() takes an "uint position", while similar functions take an "int \
> >                 index"
> > * numBeams(), beamColor() should be const
> > 
> > All in all though, pretty cool class! Just needs some API polish. :)

* The "beam order" related API (addBeam() & co) is a bit awkward. I'd prefer more \
explicit initialization, something like setBeamColor() There is actually already a \
setBeamColor().  I could change addBeam(color) to addBeam(); setBeamColor(0, color);  \
although that's a bit more clumsy.

The reordering of beams kinda sucks, but I don't particularly see a better way.

* removeBeam() takes an "uint position", while similar functions take an "int index"
Done
* numBeams(), beamColor() should be const
Done


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1430/#review2369
-----------------------------------------------------------


On 2009-08-29 10:45:29, John Tapsell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1430/
> -----------------------------------------------------------
> 
> (Updated 2009-08-29 10:45:29)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is used by KSysGuard to plot network usage etc.  I want to make it available \
> for other people to use. 
> It is really quite feature-full, and uses a sliding window technique to minimize \
> CPU usage for drawing.  On my system (dual core 3Ghz), drawing three of these \
> graphs updating every 0.5 seconds takes about 1% of the CPU usage. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdeui/plotting/KSignalPlotter.h PRE-CREATION 
> trunk/KDE/kdeui/plotting/KSignalPlotter.cpp PRE-CREATION 
> trunk/KDE/kdeui/plotting/KSignalPlotter_p.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1430/diff
> 
> 
> Testing
> -------
> 
> It has been used in KSysGuard for ages.
> 
> It has no unit tests however :-/
> 
> 
> Screenshots
> -----------
> 
> Screenshot in action
> http://reviewboard.kde.org/r/1430/s/191/
> 
> 
> Thanks,
> 
> John
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]