[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Disable 'Leaving secure site warning' in
From:       "David Faure" <faure () kde ! org>
Date:       2009-09-28 13:47:06
Message-ID: 20090928134706.9930.42487 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1715/#review2483
-----------------------------------------------------------


Did you test that the warning still appears when clicking on links, in both web \
engines, in both the "standalone page" case and inside frames? BrowserRun is used as \
a base class in both konqueror (KonqRun) and khtml (BrowserRun, used for frames). I'm \
not 100% sure, but I'm afraid this change might have removed the warnings in a case \
where they are needed. Hmm, well, the metadata comes from khtmlpart in the first \
place, so maybe it works, I just want to ask if you tested the case where the \
warnings -should- appear :-)


- David


On 2009-09-27 00:03:23, adawit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1715/
> -----------------------------------------------------------
> 
> (Updated 2009-09-27 00:03:23)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch disables the 'leaving secure site' warning from being displayed when the \
> user types a new address in the location bar while visiting an SSL secured site.  
> As far as I am concerned it only makes sense to prompt the user with such warning \
> on non-secure link navigation, i.e. a click on a link in a secure page that points \
> to a non-secure page or a non-secure script based navigation which the user might \
> not notice. And these two situations are conditions that should be handled by the \
> browsing engines directly. 
> 
> Diffs
> -----
> 
> /branches/KDE/4.3/kdelibs/kparts/browserrun.cpp 1024592 
> 
> Diff: http://reviewboard.kde.org/r/1715/diff
> 
> 
> Testing
> -------
> 
> Tested with both webkit and khtml rendering engines.
> 
> 
> Thanks,
> 
> adawit
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]