From kde-core-devel  Fri Sep 25 09:55:06 2009
From: "Marco Martin" <notmart () gmail ! com>
Date: Fri, 25 Sep 2009 09:55:06 +0000
To: kde-core-devel
Subject: Re: Review Request: Use window() as
Message-Id: <20090925095506.6070.97663 () localhost>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=125387252908052


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1707/#review2465
-----------------------------------------------------------

Ship it!


well, looking at all the code again it would just have th same effect of setAssociatedWidget(0), simply the activated signal(clicking) won't do anything by itself but forward the signal itself, you're right, i need to expand the apidox on that.

aaanyways, the patch looks good, please go for it.

- Marco


On 2009-09-24 03:20:31, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1707/
> -----------------------------------------------------------
> 
> (Updated 2009-09-24 03:20:31)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Summary
> -------
> 
> Use the window() of the passed parent() as the associated widget to avoid creating a native widget for the child due to all the winId() calls. Alien widgets are much faster.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/notifications/knotificationitem.cpp 1027406 
> 
> Diff: http://reviewboard.kde.org/r/1707/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
>