[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Two KIO::AccessManager patches...
From:       "Dawit A." <adawit () kde ! org>
Date:       2009-09-24 15:22:45
Message-ID: 200909241122.45119.adawit () kde ! org
[Download RAW message or body]

On Thursday 24 September 2009 04:42:03 David Faure wrote:
> On Thursday 24 September 2009, Dawit A. wrote:
> > Improved #2 Patch:
> >
> > Instead of chaning the QNetworkReply error code value which might
> 
> have
> 
> >  other ramifications, send the KIO error code as an attribute,
> 
> specifically
> 
> >  using the QNetworkRequest::UserMax attribute...
> 
> Should there be a typedef for that enum value in AccessManager.h,
> so that it's documented that this is the enum value used for it?

I guess it should, but we currently use QNetworkRequest::User in 
KIO::AccessManager already as well. Perhaps we need our own enum 
and simply cast that away to QNetworkRequest::Attribute when used ? 
Dunno...
 
[prev in list] [next in list] [prev in thread] [next in thread]