From kde-core-devel Wed Sep 23 06:10:46 2009 From: Martin =?iso-8859-15?q?Gr=E4=DFlin?= Date: Wed, 23 Sep 2009 06:10:46 +0000 To: kde-core-devel Subject: Re: [PATCH] Turn Powerdevil suspend notification into a dialog Message-Id: <200909230810.59834.ubuntu () martin-graesslin ! com> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=125369300615511 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart2402977.OF9i1lhVjB" --nextPart2402977.OF9i1lhVjB Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Am Mittwoch 23 September 2009 00:47:18 schrieb Aaron J. Seigo: > On September 22, 2009, Thomas L=FCbking wrote: > > Regarding this is /the/ moment to break the users workflow and pull his > > excllusive focus, one could make this a fs window (covering Aarons "user > > confused about dialog source" argument) >=20 > or "how to piss off a user because the developer thinks they know better" >=20 > modal behavior is evil, interrupting the user is a sin. never, ever get in > the way of what the user is doing. if you must get in their way, only do > so when they have explicitly said you may. >=20 > so i go back to: what is the actual real world failure we are attempting = to > fix? right now we have fixes for something that isn't, as far as we know, > actually broken. and the fix introduces a new kind of broken. I couldn't agree more. Please do not turn the notification into a modal dia= log.=20 New dialogs are only opened when you interact with your windows. I only get= =20 dialogs without previous interaction on session startup (KWallet) and=20 connectivity problems in KMail (that's IMO a bug). All other dialogs are=20 opened in response to an action. Dialogs which just pop up can be considere= d=20 broken by design and that's one of the reasons we have a focus stealing=20 prevention (yes I read that the dialog shouldn't steel focus, which actuall= y=20 doesn't matter). So how does it look like for the user? Browsing the web, clicking a link=20 resulting in a dialog telling the user that the system will power down in 1= 0=20 seconds. Yes it's unrelated but for the user it will look related. And actually I have to ask you: have you tested it? Have you tested if the= =20 dialog is shown when a window is run in fullscreen? Have you tested how the= =20 dialog behaves if there are other windows kept above? What if another dialo= g=20 opens at the same spot at the same time? What if a user has a window rule t= o=20 not show such dialogs? What if a user runs Compiz or $otherWM? For all thos= e=20 questions we have an answer when using notifications. It's tested. Replacing the notification by a dialog would realy be a step back. Please d= on't=20 do it, just because Canonical doesn't like Actions on notifications (yes to= me=20 this thread looks exactly like another try from Canonical to get their desi= red=20 behaviour). If we realy have a problem with this notification we should fix it in the p= lace,=20 like increasing the timeout. We can flash the notification like the demands= =20 attention entry in the task bar, we can paint it in read, we can put=20 exclamation marks on it, we can dim the screen, we can do whatever you want= to=20 get more attention to the notification. Last but not least: we're talking about a suspend action. No harm is done w= hen=20 the computer goes into suspend. There is no data loss or anything. This is = not=20 the kind of action that requires a click now or die dialog. --nextPart2402977.OF9i1lhVjB Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iJwEAAECAAYFAkq5u+YACgkQ/umpWjNT6CLXNAQAnkCViaLGqvnQApLrhuxZC5pH 5E+uXHgOqxCsciMBY5kV+kYXOoswJetvq0WK6sCieipBPd95XzBixzHClzRtuSIs DAmDeE3VV+3UlKYW5G3HmSscBB2uKmivYlZW/+LHSfR9OBxVrwoUu0kSKM6Rqjmt 5g/tAFLLl4rUO9m6nQo= =vtYT -----END PGP SIGNATURE----- --nextPart2402977.OF9i1lhVjB--