From kde-core-devel  Fri Sep 18 17:57:10 2009
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: Fri, 18 Sep 2009 17:57:10 +0000
To: kde-core-devel
Subject: Re: Feedback on KNotificationItem
Message-Id: <200909181157.11110.aseigo () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=125329670831285
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart6437916.XgBCfIWqIJ"

--nextPart6437916.XgBCfIWqIJ
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On September 15, 2009, Michael Pyne wrote:
> - What does eventFilter do for an icon with no widget?  It's protected, n=
ot
> private, so it should still be documented a bit I think.

it's a reimplementation of a standard QObject method. that it's a reimp can=
 be=20
noted in the apidox but isn't out of the ordinary.

> - It may be prudent to give an example of a "secondary" activate action, =
as
> mentioned in the source code (middle-click)

my only concern with that is then people start developing apps thinking=20
"secondary activation" means "middle click" when that is certainly not=20
guaranteed in any way. the apidox would need to be VERY clear on that matte=
r.

> - The detailed description mentioned the Dbus spec.  Is the spec available
> online to be linked to?

it's still a draft, but it is available both on gitorious as well as online=
=20
somewhere. Marco probably has the link to the most recent version closer to=
=20
him than i do.

> - Several signals are referenced in the APIDOX but not defined (presumably
> they're private?)  For instance newToolTip() and newStatus().

they are not private, they are part of the DBus spec

> - showMessage() is completely undocumented from what I can tell.

yes, it is currently undocumented. we may end up instead providing a method=
=20
that takes a KNotification object but which does essentially the same thing=
=20
(to the app developer's POV)

> One thing that is hampering the port is that JuK has a "track announcement
> popup" that pops up next to the system tray icon.  Without the embeddable
> widget, JuK doesn't know where the icon is.

that's because this idea, as implemented, assumes things one can not assume=
=20
about a modern system. such announcements should be associated with the=20
KNotificationItem and then the visualization(s) should decide how to displa=
y=20
them.

what we need to figure out is how to associate such things with the KNI.
=20
> So, can I use KNotify for this (the popup would need to support graphics,
>  rich text, and at least two buttons)?  Would KNotification show up in the
>  right spot?

not currently, but it's something we'd like to make happen. it would mean=20
coordinating the notifications and the notification item specs, but i think=
=20
that makes the most sense.

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

--nextPart6437916.XgBCfIWqIJ
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAkqzyfcACgkQ1rcusafx20PIOQCgk65Fag6Nrd1uTjkah64ikxBr
4L0An3GkayyhDeO9H+VxYzxfTwnT99r2
=DR0i
-----END PGP SIGNATURE-----

--nextPart6437916.XgBCfIWqIJ--