Need to exclude the 407 case as well. Other than that it looks fine to me.

On Friday 18 September 2009 10:12:25 Matthew Dawson wrote:
> This review request has been idle for over 3 weeks now.  Is it ok to commit
>  this patch yet?  This issue may cause further issues for others that have
>  to use http authentication that do not return error pages.
> 
> Thank You
> 
> Matthew
> 
> On Monday 24 August 2009 07:01:00 Matthew Dawson wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1236/
> > -----------------------------------------------------------
> >
> > (Updated 2009-08-24 11:01:00.399500)
> >
> >
> > Review request for kdelibs.
> >
> >
> > Changes
> > -------
> >
> > (Bump)
> >
> > Update the description to be more clear.
> >
> >
> > Summary (updated)
> > -------
> >
> > This patch fixes commit r707403.  Commit r707403 makes websites that
> > require http authentication , but return no error page, kio_http returns
> > an error of page not found.  Commit r707403 attempts to fix errors in
> > Konqueror when no error page is returned by the server when an error
> > occurs.  It also blocks a 401 from being properly handled when no error
> > page is returned.  This bug is set off when eGroupware is used with the
> > groupdav resource (thus the related bug).  This patch fixes the issue by
> > ignoring a 401 error code in the handling.  401's do not cause the
> > original issue that Commit r707403 fixed.
> >
> >
> > This addresses bug 186763.
> >     https://bugs.kde.org/show_bug.cgi?id=186763
> >
> >
> > Diffs
> > -----
> >
> >   /trunk/KDE/kdelibs/kioslave/http/http.cpp 1008022
> >
> > Diff: http://reviewboard.kde.org/r/1236/diff
> >
> >
> > Testing (updated)
> > -------
> >
> > Removing the 401 from the case doesn't cause the original bug report
> > (147812) to regress.  When clicking cancel on the password dialog, the
> > same error page occurs in konqueror.  When clicking ok with a blank
> > username/password, nothing happens, but the same behaviour happens
> > without the patch.  Wrong passwords do the same thing as well.
> >
> > Testing done with KDE 4.3.0 and KDE svn.  Web server was lighttpd. 
> > Authentication was tested with mod_auth and the groupdav support in
> > egroupware running on the local system.  Tested with both kioclient and
> > konqueror.
> >
> >
> > Thanks,
> >
> > Matthew
>