[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdelibs (tests) doesn't build against qt 4.6.0-tp1
From:       Thiago Macieira <thiago () kde ! org>
Date:       2009-09-17 12:24:50
Message-ID: 200909171424.50371.thiago () kde ! org
[Download RAW message or body]


Em Quinta-feira 17 Setembro 2009, às 10:21:14, você escreveu:
> On Thursday 17 September 2009, Thiago Macieira wrote:
> > Em Quarta-feira 16. Setembro 2009, às 23.17.31, David Faure escreveu:
> > > I think you're assuming that we were #including qtestmouse.h directly,
> > > but we were not. It turns out the tests were including QTestEvent,
> >
> > It looks like QTestEvent is entirely GUI-only, so the check could be
> > moved to what includes it.
> 
> Nothing includes it, apart from qtest_gui.h, it seems.
> (and the gui-related forwarding headers of course)
> 
> And qtest.h already uses ifdef QT_GUI_LIB around <qtest_gui.h>
> So it seems to me that you could just remove the ifdef QT_GUI_LIB from
> qtestevent.h

Yep.

The problem is verifying that this doesn't break anything...

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
      http://qt.nokia.com/qtdevdays2009

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]