[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Adding kinetic scrolling in plasma::ScrollWidget
From:       "Adenilson Cavalcanti" <cavalcantii () gmail ! com>
Date:       2009-09-16 23:37:29
Message-ID: 20090916233729.30276.42178 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1614/
-----------------------------------------------------------

(Updated 2009-09-16 23:37:29.183313)


Review request for kdelibs, Aaron Seigo, Marco Martin, and igorto.


Changes
-------

> From the previous todo list, all were done. What is missing is only 'making it more \
> generic' and 'using QPropertyAnimation'.

I think that a approach would be to have a factory in KineticScrolling to that 2 \
                implementations could be created:
- one using simple timers (the current code)
- another one using Qt 4.6 animation API


Summary
-------

Adding kinetic scrolling in plasma::ScrollWidget using timers.


Diffs (updated)
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/CMakeLists.txt 1024503 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp \
PRE-CREATION   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h \
PRE-CREATION   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h \
1024503   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp \
1024503 

Diff: http://reviewboard.kde.org/r/1614/diff


Testing
-------

Up until now, only tested it with uBlog and plasma-netbook, not sure how it will work \
with another plasma apps.


Thanks,

Adenilson


[prev in list] [next in list] [prev in thread] [next in thread]