[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: When a .desktop file (app shortcut) is modified
From:       "David Faure" <faure () kde ! org>
Date:       2009-09-14 9:46:21
Message-ID: 20090914094621.7451.65090 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1390/#review2343
-----------------------------------------------------------


I'm surprised, because the idea was that the local desktop file would be merged with \
the global one. (If it does not, then we should just copy the whole file first....)

So IMHO instead of copying one field (and leaving all others as un-specified, so the \
problem isn't really fixed overall), we should find out if the global-local merging \
is supposed to work or not, in this particular case, and if not, copy the whole file.


- David


On 2009-08-23 20:38:10, Darío Andrés wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1390/
> -----------------------------------------------------------
> 
> (Updated 2009-08-23 20:38:10)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Mh, I don't really know if this is a big deal but I wanted to try to fix it. (I'm \
> not even sure if the workflow that derived in bug 164472 is a valid one just to try \
> to fix this) 
> The file properties dialog only saves the icon field in the .desktop files; if the \
> icon was indeed changed. However, there is one more case in which saving the icon \
> field will be needed: when modifying an icon/desktop that represents a system-wide \
> .desktop file; changing some attribute. This will cause the .desktop to be \
> rewritten to a local place (~/.local/share/applications/kde4); but the \
> DesktopPlugin of the file properties will not write the Icon field;  causing this \
> new icons to have an unknown/invalid/empty icon. 
> The patch checks if the path changed from the start upto the save moment; and will \
> force saving the Icon field if the file was also a .desktop one 
> 
> This addresses bug 164472.
> https://bugs.kde.org/show_bug.cgi?id=164472
> 
> 
> Diffs
> -----
> 
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kio/kfile/kpropertiesdialog.cpp \
> 1013119  
> Diff: http://reviewboard.kde.org/r/1390/diff
> 
> 
> Testing
> -------
> 
> Primary testing: it worked; and fixed bug 164472. Editing a local desktop file \
> without changing the icon didn't applied the icon field again. 
> I see a trailing space. If I commit this I'm going to remove it.
> 
> 
> Thanks,
> 
> Darío
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]