From kde-core-devel  Fri Sep 04 08:54:47 2009
From: Adriaan de Groot <groot () kde ! org>
Date: Fri, 04 Sep 2009 08:54:47 +0000
To: kde-core-devel
Subject: Re: [PATCH] Detecting notification popup server capabilities
Message-Id: <200909041054.47476.groot () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=125205452803527
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart2544952.sPhI6J1keG"

--nextPart2544952.sPhI6J1keG
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday 04 September 2009 12:05:02 am John Tapsell wrote:
>  notify->setActions( i18n("View,Ignore").split(',') );

Relies on , being preserved in the translations and would need a lot of=20
context to make this understandable to translators. Use a QStringList inste=
ad,=20
even if it's more typing for the developer.

> I can't think of a decent example where you'd want different text when
> no actions are available, but maybe also useful so that you could do
> notify->setNoActionText("")  or something for the action to be ignored

Do not use "" when you mean QString().

Yes, you're brainstorming API. Even so, there's API consistency to be thoug=
ht=20
of.

[ade]

--nextPart2544952.sPhI6J1keG
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQEcBAABAgAGBQJKoNXXAAoJEFmjNZoDOer9UjQH/23TInM8lsHBRVCEp094PU+2
eqrcMxKH+c5Ue6O5nLZEOj3DbqsaSQ1gUrM8A9zmr1zc91AwTqC+C+Zk/27HHJBC
8JdRP8/8PuDBHXoQyFd7wPvfnV/oZwBkJTrAzIhCCooe1HupUwLL2CgYzPlr7I9i
NxT8AvZt7bTqQS3SMC1UagpB2BiaoEFAFWlyNlSsbSfwFQFePqtwUm4UesX6p9H3
W8FtAVIy+5xJgUFFqvIbLLqXRMP68O9pEGypIzpB+7cZ7EnskfQhFAAxUk60LepB
/8eyiQuwMCB9XjSViQDEFtSUhB01faP9R5QEU5JZNdIn+9wxyc+gnH8Onc2PK94=
=6tXO
-----END PGP SIGNATURE-----

--nextPart2544952.sPhI6J1keG--