[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDE Trunk based on Qt 4.6
From:       Christoph Feck <christoph () maxiom ! de>
Date:       2009-08-30 19:11:36
Message-ID: 200908302111.36826.christoph () maxiom ! de
[Download RAW message or body]

Am Sunday 30 August 2009 20:34:48 schrieb Benjamin Meyer:
> On Aug 30, 2009, at 12:14 PM, Christoph Feck wrote:
> > Am Sunday 30 August 2009 17:13:14 schrieb Thiago Macieira:
> >> Em Domingo 30. Agosto 2009, ās 16.49.55, Christoph Feck escreveu:
> >>> Ideally, I would just svn commit to qt-copy with a fix, add a BUG:
> >>> or a
> >>> QTISSUE: number, and request merging with upstream Qt using a
> >>> QTMERGE
> >>> tag. Done. It cannot get simpler. Post-commit review works.
> >>
> >> That's exactly what we're asking of you.
> >>
> >> Create the fix, commit it, push to Gitorious, then create an MR
> >> saying
> >> "here, I fixed the issue".
> >
> > No. Browsing KDE/Qt sources in the editor. Find a bug. Correct that.
> > Hit save.
> > Want to commit.
> >
> > For KDE sources I have to:
> >
> > 0. "svn up/diff" to be sure
> > 1. "svn commit" with BUG: number
> > 2. "svnbackport" if I want it in stable branch
> > 3. go back to editor to look for the next file I could fix
>
> And then I revert your commit because it broke something that would
> have been caught if you had bother to ask for a review from the guy
> who maintains the code.

That's fine. If you want to review the commit, do that. But it should not have 
an impact on my workflow.

Christoph Feck (kdepepo)

[prev in list] [next in list] [prev in thread] [next in thread]