[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [mini-patch] make KHTMLView scrolling stop when moving view via API
From:       Martin Koller <kollix () aon ! at>
Date:       2009-08-28 21:07:25
Message-ID: 200908282307.26045.kollix () aon ! at
[Download RAW message or body]


Obviously kfm-devel was the wrong list to ask. So here I go again:

Hi,

The bug https://bugs.kde.org/show_bug.cgi?id=184273
mentions that KHTMLView will not stop auto scrolling when one presses key 
up/down.
This is due to the fact the KHTMLView does not stop it's internal timer when
one calls its scrollBy() Method, which is what kmail does.

I suggest the following patch.
Is this ok for commit ?


Index: khtmlview.cpp
===================================================================
--- khtmlview.cpp       (Revision 1013649)
+++ khtmlview.cpp       (Arbeitskopie)
@@ -746,6 +746,8 @@

 void KHTMLView::scrollBy(int x, int y)
 {
+   if (d->scrollTimerId)
+       d->newScrollTimer(this, 0);
    horizontalScrollBar()->setValue( horizontalScrollBar()->value()+x );
    verticalScrollBar()->setValue( verticalScrollBar()->value()+y );
 }

-- 
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail 
          /\                        - against microsoft attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]