[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Extend khtml API to allow retrieval of the
From:       "Maksim Orlovich" <mo85 () cornell ! edu>
Date:       2009-08-21 16:09:56
Message-ID: 63465.24.58.22.16.1250870996.squirrel () webmail ! cornell ! edu
[Download RAW message or body]

>
> This change should be BC according to the rules at
> http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++
> because it only adds new non-virtual functions (but
> StringsMatcher::isMatched() becomes overloaded, so not SC).  When possible
> (KDE5?), the two overloads of this can be merged into one with a default
> argument.

StringsMatcher is a private class, so you can change methods freely, and
hence can merge the two methods right now.

I am a bit confused by the behavior of adFilteredBy when the URL is
whitelisted, though.

The KHTMLSettings new method needs @since...

Everything else looks good,
Maks


[prev in list] [next in list] [prev in thread] [next in thread]