[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Allow the use of KModifierKeyInfo in contexts
From:       "David Faure" <faure () kde ! org>
Date:       2009-08-20 10:58:08
Message-ID: 20090820105808.20873.55159 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/930/#review2094
-----------------------------------------------------------


No experience with such filters so I can't really review it. I only noticed that the \
iterators should be const_iterators since they don't modify the list (and then use \
constBegin/constEnd).

Also, if KModifierKeyInfoProvider are often create/destructed, the list could be a \
qset to speed up the removeAll(this).

- David


On 2009-08-10 12:11:30, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/930/
> -----------------------------------------------------------
> 
> (Updated 2009-08-10 12:11:30)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Currently KModifierKeyInfo needs a KApplication to install the event filter and \
> dumps a warning if it isn't available. This patch makes it possible to use it in \
> QApplication-only apps (eg. kdm) by installing the event filter using \
> QAbstractEventDispatcher. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kdeui/util/kmodifierkeyinfoprovider_p.h 1008830 
> /trunk/KDE/kdelibs/kdeui/util/kmodifierkeyinfoprovider_x11.cpp 1008830 
> 
> Diff: http://reviewboard.kde.org/r/930/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]