[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix description handling in Places entry editor
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2009-08-19 23:16:17
Message-ID: 20090819231617.7806.28200 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1312/
-----------------------------------------------------------

(Updated 2009-08-19 23:16:17.023426)


Review request for Dolphin and kdelibs.


Changes
-------

* renamed "description" to "label" in code. As the class is internal (not exported), \
                I also renamed the accessor function. I hope this is okay.
* renamed "m_edit" to "m_labelEdit"
* white space changes, as requested


Summary
-------

This fixes a few problems with the "Description" of file places:

* it says "Description", but you are not going to enter a description, but only a \
                (descriptive) label
* the "Enter description here" is not a clickMessage, but the actual default text
* due to setting this, automatic derivation of label from URL does not work as \
                intended
* label derivation from URL fails for URLs without path or host (e.g. \
"ftp://ftp.test.org/", "music://")

Please also review string changes.


This addresses bug 159971.
    https://bugs.kde.org/show_bug.cgi?id=159971


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kfile/kfileplacesview.cpp 1013177 
  /trunk/KDE/kdelibs/kfile/kfileplaceeditdialog.cpp 1013177 
  /trunk/KDE/kdelibs/kfile/kfileplaceeditdialog.h 1013177 

Diff: http://reviewboard.kde.org/r/1312/diff


Testing
-------


Thanks,

Christoph


[prev in list] [next in list] [prev in thread] [next in thread]