----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1230/#review2086 ----------------------------------------------------------- Ship it! Looks good. - David On 2009-08-06 21:54:05, Ivo Anjo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1230/ > ----------------------------------------------------------- > > (Updated 2009-08-06 21:54:05) > > > Review request for kdelibs. > > > Summary > ------- > > Patch to fix bug 191016: when trying to open a folder with KFileDialog and there are no permissions to access it, it fails silently, without an error. > > > This addresses bug 191016. > https://bugs.kde.org/show_bug.cgi?id=191016 > > > Diffs > ----- > > trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1000921 > > Diff: http://reviewboard.kde.org/r/1230/diff > > > Testing > ------- > > With this patch, I correctly get an error when trying to access a folder for which my user has no permissions. All other interactions with files work as before. > > > Thanks, > > Ivo > >