From kde-core-devel  Tue Aug 18 15:17:39 2009
From: Thiago Macieira <thiago () kde ! org>
Date: Tue, 18 Aug 2009 15:17:39 +0000
To: kde-core-devel
Subject: Re: Review Request: Fix sanitization of dbus path in KMainWindow
Message-Id: <200908181717.39699.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=125060871019512
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart2090355.sjLaG5GqYY"

--nextPart2090355.sjLaG5GqYY
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable

Em Ter=E7a-feira 18 Agosto 2009, =E0s 15:34:12, voc=EA escreveu:
> Am Tuesday 18 August 2009 schrieb Thiago Macieira:
> > It means you just misused QString.
>=20
> Indeed - forcing QString::fromUtf8("=DF") makes it work as expected.
> Good to know =3DD
> (The Qt docu states that QString(const *char) makes implicit use of
> QString::fromAscii())
>=20
> > Please compile your code with #define QT_NO_CAST_FROM_ASCII and
> > QT_NO_CAST_TO_ASCII.
>=20
> this would be more like a call to whoever set an objectName/appName using
> utf-8 (and is pretty nasty in it's effect, btw ;-)
>=20
> Another thing:
> the '_' substitution may be ambigious as e.g. "_sen" and "_sen" are the
>  very same strings...
> i'd suggest to insert _<unicode>_ instead, so "_214_sen" and "_228_sen"
>  remain individual (unless not used othwerwise... it's a far corner case
>  anyway)

Unnecessary. I doubt we'll have such objects.

They are often identifier names already.

=2D-=20
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
      http://qt.nokia.com/qtdevdays2009

--nextPart2090355.sjLaG5GqYY
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQBKisYTM/XwBW70U1gRAk7QAJ4wET5Yw0EfIDEjp620eo8kCYdgDACcCnVS
RvpwUbZKlYcMZ5SaXonnPKc=
=vgdg
-----END PGP SIGNATURE-----

--nextPart2090355.sjLaG5GqYY--