From kde-core-devel  Tue Aug 18 06:25:02 2009
From: Thiago Macieira <thiago () kde ! org>
Date: Tue, 18 Aug 2009 06:25:02 +0000
To: kde-core-devel
Subject: Re: Review Request: Fix sanitization of dbus path in KMainWindow
Message-Id: <200908180825.02696.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=125057675928144
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart13463844.y552EdhFNM"

--nextPart13463844.y552EdhFNM
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Matthew Woehlke wrote:
>+    QString pathname =3D QString( q->objectName().toAscii() );

No. Don't ever do that.
=2D-=20
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
      http://qt.nokia.com/qtdevdays2009

--nextPart13463844.y552EdhFNM
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQBKikk+M/XwBW70U1gRAg2UAJ95eG7zLn/8kF5VbF0vZA0d9Z1FsACePFL1
dyv9LFHtf9EjQZM02m8djjU=
=EIeS
-----END PGP SIGNATURE-----

--nextPart13463844.y552EdhFNM--