[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: KPixmapSequence: painting spinners made easy
From:       Michael Leupold <lemma () confuego ! org>
Date:       2009-08-17 14:56:29
Message-ID: 200908171656.29383.lemma () confuego ! org
[Download RAW message or body]

Am Montag, 17. August 2009 16:52:50 schrieb Sebastian Trueg:
> > On 2009-08-17 11:14:00, Michael Leupold wrote:
> > > trunk/KDE/kdelibs/kdeui/util/kpixmapsequencewidget.cpp, line 90
> > > <http://reviewboard.kde.org/r/1345/diff/2/?file=10189#file10189line90>
> > >
> > >     I think that's superfluous.
> >
> >  wrote:
> >     I agree. It was just added for convenience.
>
> I am really not used to this review board yet. No, I think it makes sense
> to stop the animation when the widget is hidden. Why continue to fire a
> timer?

Actually I was just referring to the redeclaration of ::hideEvent in the C++, 
not the definition of KPixmapSequenceWidget::hideEvent which is of course 
fine.

Regards,
Michael
[prev in list] [next in list] [prev in thread] [next in thread]