[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Patch KIO::TCPSlaveBase...
From:       "Dawit A." <adawit () kde ! org>
Date:       2009-08-16 12:49:33
Message-ID: 200908160849.33426.adawit () kde ! org
[Download RAW message or body]

If you currently visit a secure (SSL protected) website (e.g. gmail.com) and 
click on a link to a non ssl protected site in the page (e.g. "About Gmail" at 
the above site), you are presented with a warning that you are about to leave 
the secure site, ofcourse unless you have already clicked on the "Do not 
show..." checkbox in this dialog before. Anyhow, if you press the cancel 
button on this dialog, the request gets canceled by the ioslave but the 
application will never receive a finished or error signal. In Konqueror this 
means the K logo will spin and the stop button will be active indefinitely.

The attached patch addresses the above mishap by sending the correct error 
message just as it does when a connection attempt fails.

["tcpslavebase.patch" (text/x-patch)]

Index: /home/dalemayehu/work/KDE/source/branches/kdelibs/kio/kio/tcpslavebase.cpp
===================================================================
--- /home/dalemayehu/work/KDE/source/branches/kdelibs/kio/kio/tcpslavebase.cpp	(revision 1011399)
+++ /home/dalemayehu/work/KDE/source/branches/kdelibs/kio/kio/tcpslavebase.cpp	(working copy)
@@ -318,6 +318,7 @@
                                     "WarnOnLeaveSSLMode");
 
             if (result == KMessageBox::Cancel) {
+                error(ERR_USER_CANCELED, host);
                 return false;
             }
         }


[prev in list] [next in list] [prev in thread] [next in thread]