[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Remove some warnings when compiled with:
From:       "Jaime Torres" <jtamate () gmail ! com>
Date:       2009-08-15 10:30:00
Message-ID: 20090815103000.9297.65283 () localhost
[Download RAW message or body]



> On 2009-08-15 10:20:14, Torch wrote:
> > good idea, but please do not re-initialize properties in the ctor body, \
> > especially in a patch that is supposed to improve code quality and style ;-). 
> > so please write
> > 
> > a::a() : m_b(123) {}
> > 
> > instead of
> > 
> > a::a() : m_b(0) { m_b = 123; }

I imagine you are talking about the gzip Private constructor..

I do not see how to initialize the zStream members in the constructor list (it is a \
struct, not a class, with only the default constructors).


- Jaime


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1327/#review2029
-----------------------------------------------------------


On 2009-08-15 09:42:51, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1327/
> -----------------------------------------------------------
> 
> (Updated 2009-08-15 09:42:51)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Remove some warnings when compiled with: ADD_DEFINITIONS( -Wall -Wextra -Weffc++ \
> -Wstrict-null-sentinel -Wabi -Wreorder -Woverloaded-virtual) 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kdecore/compression/kfilterdev.cpp 1011431 
> /trunk/KDE/kdelibs/kdecore/compression/kgzipfilter.cpp 1011431 
> 
> Diff: http://reviewboard.kde.org/r/1327/diff
> 
> 
> Testing
> -------
> 
> Compiles with less warnings and konqueror works with gzipped http content.
> 
> 
> Thanks,
> 
> Jaime
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]