[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: adds focusIn and focusOut signals to KTextEdit
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2009-08-14 12:09:54
Message-ID: 20090814120954.10218.21951 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1318/#review2026
-----------------------------------------------------------


Hi, thanks for your efforts, but there is no need for this patch.

* if the programmer needs to get focus change events, he can subclass and reimplement \
the event functions, or (optionally) install an event filter

* for the proposed use case, there exists the new clickMessage() property

The patch is also wrong, as trunk is going to be "4.4", and public methods start with \
a lower case character.

- Christoph


On 2009-08-14 03:13:34, patcito wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1318/
> -----------------------------------------------------------
> 
> (Updated 2009-08-14 03:13:34)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This adds two signals to detect focus and blur on ktextedits. It's useful when you \
> want to pre-fill the textedit with some instructions and clear the text on focus. \
> Eg, the text can be "Enter text for X reason here" and when the user click on the \
> textedit it clears it or execute any other slot. (not sure whether the email \
> bounced the first time). 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kdeui/widgets/ktextedit.h 1011134 
> /trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp 1011134 
> 
> Diff: http://reviewboard.kde.org/r/1318/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> patcito
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]