[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Forwarding headers for Kross
From:       "Ben Boeckel" <mathstuf () gmail ! com>
Date:       2009-08-12 1:06:33
Message-ID: 20090812010633.4844.28162 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/655/
-----------------------------------------------------------

(Updated 2009-08-12 01:06:33.794221)


Review request for kdelibs.


Changes
-------

Seems that the old patch got corrupted(?) Reuploading patch.


Summary
-------

Kross does not currently provide the forwarding headers (#include [Kross/ClassName] \
(angle brackets aren't being escaped?)). This patch adds headers for the public \
classes as well as the install command to the CMakeLists.txt.


Diffs (updated)
-----

  trunk/KDE/kdelibs/includes/CMakeLists.txt 961773 
  trunk/KDE/kdelibs/includes/Kross/Action PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/ActionCollection PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/ActionCollectionEditor PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/ActionCollectionModel PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/ActionCollectionProxyModel PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/ActionCollectionView PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/ChildrenInterface PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/ErrorInterface PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/Interpreter PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/InterpreterInfo PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/Manager PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/MetaFunction PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/MetaType PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/MetaTypeHandler PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/MetaTypeImpl PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/MetaTypeVariant PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/MetaTypeVoidStar PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/Object PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/Script PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/ScriptingPlugin PRE-CREATION 
  trunk/KDE/kdelibs/includes/Kross/WrapperInterface PRE-CREATION 

Diff: http://reviewboard.kde.org/r/655/diff


Testing
-------

None right now, though the headers are trivial. I'm still working to get a setup for \
tracking trunk.


Thanks,

Ben


[prev in list] [next in list] [prev in thread] [next in thread]