[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix sanitization of dbus path in KMainWindow
From:       Thiago Macieira <thiago () kde ! org>
Date:       2009-08-11 17:12:19
Message-ID: 200908111912.20039.thiago () kde ! org
[Download RAW message or body]

[Attachment #2 (Text/Plain)]

Em Terça-feira 11 Agosto 2009, às 17:59:43, Matthew Woehlke escreveu:
> Well, I love how what should have been a simple review request has
> derailed into discussing what I was *trying* to get discussed in the
> previous thread, here:
> http://permalink.gmane.org/gmane.comp.kde.devel.general/58753
>
> Thiago Macieira wrote:
> > That interface name is auto-created by QtDBus itself and should be fixed
> > there.
>
> Should the existing sanitization be fixed, removed, or left broken?
> That's really all the review request is about.

I haven't looked at your fix.

But your fix is about the object path, not the interface. The interface that 
qdbus complains about comes from QtDBus itself.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
      http://qt.nokia.com/qtdevdays2009

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]