From kde-core-devel  Tue Aug 11 05:23:02 2009
From: "Chani" <chanika () gmail ! com>
Date: Tue, 11 Aug 2009 05:23:02 +0000
To: kde-core-devel
Subject: Re: Review Request: Fix sanitization of dbus path in KMainWindow
Message-Id: <20090811052302.7251.67112 () localhost>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=124996817505438


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1261/#review1969
-----------------------------------------------------------


how will this affect applications that do have a - in their name? and applications that use the dbus interface of those apps?

- Chani


On 2009-08-10 22:27:09, Matthew Woehlke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1261/
> -----------------------------------------------------------
> 
> (Updated 2009-08-10 22:27:09)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> As pointed out by Thomas Lübking ( http://permalink.gmane.org/gmane.comp.kde.devel.general/58749 ), KMainWindow attempts to sanitize what it will allow in the dbus path. However as written it would allow the illegal characters "." and "-" to be passed through.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/kmainwindow.cpp 1009802 
> 
> Diff: http://reviewboard.kde.org/r/1261/diff
> 
> 
> Testing
> -------
> 
> built kdelibs and ran a KDE application
> 
> 
> Thanks,
> 
> Matthew
> 
>