[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] kdirwatch problem of detecting hard link change
From:       sycao <sycao () redflag-linux ! com>
Date:       2009-08-07 9:57:40
Message-ID: 4A7BFA94.8000907 () redflag-linux ! com
[Download RAW message or body]

Pau Garcia i Quiles wrote:
> On Fri, Aug 7, 2009 at 7:23 AM, sycao<sycao@redflag-linux.com>  wrote:
>    
>> sonald wrote:
>>      
>>>   the problem comes up  when  I  traced the problem when using kcmshell4
>>> clock
>>>   to set timezone, which is when you changed timezone second time,
>>>   the setting just lost. I found the real problem is that
>>>   KDirWatch loses watch on /etc/localtime.
>>>
>>>   I can reproduce the watch lose very easily:
>>>     # inotifywait -m /etc/localtime
>>>     # zic -l Asia/Shanghai
>>>     # zic -l Asia/Muscat
>>>     # touch /etc/localtime
>>>
>>>   After Change timezone to Muscat, subsequent changes to /etc/localtime
>>>   won't be watched. because KDirWatch use inotify (I'm using a linux
>>> distro),
>>>   which monitoring file with respect to inode , not dir entry.
>>>   zic relinked ( hardlink ) /etc/localtime, so inotify just told attrib
>>>   change ( st_nlink change ) of the original file.
>>>
>>>   I post the patch a few months ago, and it seems that problem still exists
>>>   int KDE 4.3 RC, so I post here to see if it can make some help.
>>>
>>>   Sian Cao
>>>
>>>
>>>
>>>        
>> Hi, all
>>   I sent this patch for a long time, and no one review it yet. but this is
>> really a problem.
>>
>> Sian Cao
>>      
>
> Sorry, I didn't answer. I tested it at aKademy on my Ubuntu Hardy
> (kernel 2.6.24-23-generic) and it did not work for me.
>
> Fixing this bug would probably fix bug 196316 "kcmdatetimehelper does
> not set time zone correctly"
>
>    
Yes,  kdirwatch is responsible for this bug partially, which causes 
timezone daemon
tracking /etc/localtime effectively,  and I have been trying to fix 
kcontrol/dateandtime
to make a whole solution.

Sian Cao

[Attachment #3 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html; charset=ISO-8859-1"
 http-equiv="Content-Type">
  <title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
Pau Garcia i Quiles wrote:
<blockquote
 cite="mid:3af572ac0908070028k15fb4478ia501a5829d7b9916@mail.gmail.com"
 type="cite">
  <pre wrap="">On Fri, Aug 7, 2009 at 7:23 AM, sycao<a class="moz-txt-link-rfc2396E" \
href="mailto:sycao@redflag-linux.com">&lt;sycao@redflag-linux.com&gt;</a> wrote:  \
</pre>  <blockquote type="cite">
    <pre wrap="">sonald wrote:
    </pre>
    <blockquote type="cite">
      <pre wrap="">&nbsp;the problem comes up &nbsp;when &nbsp;I &nbsp;traced the \
problem when using kcmshell4 clock
&nbsp;to set timezone, which is when you changed timezone second time,
&nbsp;the setting just lost. I found the real problem is that
&nbsp;KDirWatch loses watch on /etc/localtime.

&nbsp;I can reproduce the watch lose very easily:
&nbsp; &nbsp;# inotifywait -m /etc/localtime
&nbsp; &nbsp;# zic -l Asia/Shanghai
&nbsp; &nbsp;# zic -l Asia/Muscat
&nbsp; &nbsp;# touch /etc/localtime

&nbsp;After Change timezone to Muscat, subsequent changes to /etc/localtime
&nbsp;won't be watched. because KDirWatch use inotify (I'm using a linux
distro),
&nbsp;which monitoring file with respect to inode , not dir entry.
&nbsp;zic relinked ( hardlink ) /etc/localtime, so inotify just told attrib
&nbsp;change ( st_nlink change ) of the original file.

&nbsp;I post the patch a few months ago, and it seems that problem still exists
&nbsp;int KDE 4.3 RC, so I post here to see if it can make some help.

&nbsp;Sian Cao



      </pre>
    </blockquote>
    <pre wrap="">Hi, all
&nbsp;I sent this patch for a long time, and no one review it yet. but this is
really a problem.

Sian Cao
    </pre>
  </blockquote>
  <pre wrap=""><!---->
Sorry, I didn't answer. I tested it at aKademy on my Ubuntu Hardy
(kernel 2.6.24-23-generic) and it did not work for me.

Fixing this bug would probably fix bug 196316 "kcmdatetimehelper does
not set time zone correctly"

  </pre>
</blockquote>
Yes,&nbsp; kdirwatch is responsible for this bug partially, which causes
timezone daemon <br>
tracking /etc/localtime effectively,&nbsp; and I have been trying to fix
kcontrol/dateandtime<br>
to make a whole solution.<br>
<br>
Sian Cao <br>
</body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic