[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Fix http requests to locations requiring credentials
From:       "Matthew Dawson" <matthewjd () gmail ! com>
Date:       2009-08-07 4:02:28
Message-ID: 20090807040228.959.46815 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1236/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

This patch fixes commit r707403.  When a web page is accessed that requires a set of \
credentials, but no error page is returned, kio_http returns an error of page not \
found.  Commit r707403 attempts to fix errors when no error page is returned by the \
server with an error occurs, but it also blocks a 401 from being properly handled.  \
This bug is set off when eGroupware is used with the groupdav resource (thus the \
related bug).  This patch fixes the issue by ignoring a 401 error code in the \
handling.


This addresses bug 186763.
    https://bugs.kde.org/show_bug.cgi?id=186763


Diffs
-----

  /trunk/KDE/kdelibs/kioslave/http/http.cpp 1008022 

Diff: http://reviewboard.kde.org/r/1236/diff


Testing
-------

Removing the 401 from the case doesn't cause the original bug report (147812) to \
regress.  When clicking cancel on the password dialog, the same error page occurs.  \
When clicking ok with a blank username/password, nothing happens, but the same \
behaviour happens without the patch.  Wrong passwords do the samething as well.

Testing done with KDE 4.3.0 and KDE svn.  Web server was lighttpd.  Authentication \
was tested with mod_auth and the groupdav support in egroupware running on the local \
system.  Tested with both kioclient and konqueror.


Thanks,

Matthew


[prev in list] [next in list] [prev in thread] [next in thread]