[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Old Bug in KFileWidget Reappears in KOffice
From:       Jonathan Marten <jjm2 () keelhaul ! demon ! co ! uk>
Date:       2009-07-19 17:51:44
Message-ID: ov7hy4imrz.fsf () keelhaul ! local
[Download RAW message or body]

Fredy Yanardi <fyanardi@gmail.com> writes:
> I just updated my kdelibs and found out that KOffice applications
> always crash at startup with an assertion failure in KFileWidget:
> 
> #11 0xb6fbe82c in qt_assert (assertion=0xb59cd32e "d->ops", file=0xb59ccbb0 \
> "/home/kde-devel/kde/src/KDE/kdelibs/kfile/kfilewidget.cpp", line=1724) at \
> /home/kde-devel/kde/src/qt-copy/src/corelib/global/qglobal.cpp:1786 #12 0xb598e498 \
> in KFileWidget::showEvent (this=0x870c9b0, event=0xbf90f7f0) at \
> /home/kde-devel/kde/src/KDE/kdelibs/kfile/kfilewidget.cpp:1724 
> Further investigation shows that there is a synchronous job inside the constructor \
> added by last commit to KFileWidget (revision 998710), and the show event is called \
> before this synchronous job completes, which causes d->ops to be 0. This seems to \
> be exactly the same kind of bug fixed last year: \
> http://bugs.kde.org/show_bug.cgi?id=172678

Oops, that was my commit.  The reason for trying to move the job to
before the creation of the d->urlNavigator was that, if a startDir
with a full path plus suggested filename was passed to this
constructor, that would get inserted as is in the old-style URL
history (but not the new breadcrumb bar).

I'll revert that change and check the testcases again.

Apologies for any inconvenience...

Regards, Jonathan

-- 
Jonathan Marten                         http://www.keelhaul.demon.co.uk
Twickenham, UK                          jjm2@keelhaul.demon.co.uk


[prev in list] [next in list] [prev in thread] [next in thread]