[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KColorDialog slot naming
From:       Parker Coates <parker.coates () gmail ! com>
Date:       2009-07-07 11:24:57
Message-ID: 85d347350907070424k29b940b1ucf92442a0d182a57 () mail ! gmail ! com
[Download RAW message or body]

On Thu, Jul 2, 2009 at 10:59 PM, John Tapsell wrote:
> Hi all,
>
>  The API for KColorDialog is somewhat unfortunate.  Currently we have a signal:
>
>     void colorSelected( const QColor &col );
>
>  Which is emitted immediately when a color is selected.
>  Qt instead has:
>
>     void colorSelected( const QColor &col );
>     void currentColorSelected( const QColor &col );
>
>  Where "currentColorSelected" behaves like our "colorSelected" and
> "colorSelected" is emitted only once - when the user presses Ok.
>
>  I would like to have a signal like Qt's "colorSelected", but any
> idea how we can solve this tangle?

Call it "finalColorSelected", maybe?

Whatever you do, add big warnings to the API documentation of both
signals to explain the discrepancy with the Qt versions and a add
comment in the code to straighten this out for KDE5.

Parker

[prev in list] [next in list] [prev in thread] [next in thread]