[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Support decimal font sizes (such as 8.6 pt) in
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2009-06-28 22:12:38
Message-ID: 20090628221238.3066.95342 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/904/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Changes KFontDialog and related classes (KFontChooser, KFontRequester) to support \
fractional font sizes (currently, only one decimal digit is supported, I guess this \
is sufficient to close the bug report).

QFont already had support for fractional font sizes. Applications that do not use \
QFont::pointSizeF() but pointSize() will get the rounded size. Most applications, \
however, simply request a font, use it, or store it using KConfig, so they will \
support fractional font sizes transparently.

There may be a need for a KFontSizeFAction class in KDE, but before I add anything to \
KDE, I better ask for a review :)


This addresses bug 122618.
    https://bugs.kde.org/show_bug.cgi?id=122618


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/fonts/kfontchooser.h 988753 
  /trunk/KDE/kdelibs/kdeui/fonts/kfontchooser.cpp 988753 
  /trunk/KDE/kdelibs/kdeui/fonts/kfontcombobox.cpp 988753 
  /trunk/KDE/kdelibs/kdeui/fonts/kfontrequester.cpp 988753 

Diff: http://reviewboard.kde.org/r/904/diff


Testing
-------


Thanks,

Christoph


[prev in list] [next in list] [prev in thread] [next in thread]