[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: KColorSpace::KHCY::KHCY(const & QColor)
From:       Olivier Goffart <ogoffart () bepointbe ! be>
Date:       2009-06-23 0:57:28
Message-ID: 200906230257.28981.ogoffart () bepointbe ! be
[Download RAW message or body]

Le Monday 22 June 2009, Michael Kreitzer a écrit :
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/868/
> -----------------------------------------------------------
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> The constructor KColorSpace::KHCY::KHCY(const & QColor) has a floating
> point precision error exposed by the -ftree-pre flag in gcc 4.4 which is
> enabled with -O2 optimizations. The result is an invalid chroma calculation
> in the corner case of full white (1.0, 1.0, 1.0 in rgb). The patch works
> around this by performing an integer comparison of r, g, and b and setting
> chroma to 0.0 if all 3 are equal.


Maybe qFuzzyCompare should be used

[prev in list] [next in list] [prev in thread] [next in thread]