[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [Patch] Bashism in startkde
From:       Armin Berres <trigger () space-based ! de>
Date:       2009-06-01 19:25:08
Message-ID: 20090601192508.GK11498 () bluefire
[Download RAW message or body]

On Mon, 01 Jun 09 11:46, Oswald Buddenhagen wrote:
> On Mon, Jun 01, 2009 at 08:13:01AM +0000, Sune Vuorela wrote:
> > On 2009-06-01, Thiago Macieira <thiago@kde.org> wrote:
> > > Isn't $() another extension? Shouldn't we use `` instead?
> > 
> > It depends on what you call "extension".
> > $() is posix shell, but afaik not supported by the original Bourne
> > Shell. No one uses Bourne Shell today though.
> > 
> > I just tested:
> > 
> > FOO=$(id -u)
> > echo $FOO
> > 
> > and I get the expected output in
> > bash
> > dash 
> > posh  
> > pdksh
> > ksh93
> > mksh
> > zsh
> > 
> > (And then I ran out of shells)
> > 
> now log in into a default install of some closed-source unix and try
> again. :-P
> 
> fwiw, kde assumes a posix shell in several places, but kprocess goes
> through some hoops to make sure it gets one.

So, this one should be ok to commit then, right:

|Index: workspace/startkde.cmake
|===================================================================
|--- workspace/startkde.cmake    (revision 975766)
|+++ workspace/startkde.cmake    (working copy)
|@@ -367,7 +367,7 @@
| export KDE_SESSION_VERSION
| xprop -root -f KDE_SESSION_VERSION 32c -set KDE_SESSION_VERSION 4
|
|-KDE_SESSION_UID=$UID
|+KDE_SESSION_UID=`id -ru`
| export KDE_SESSION_UID
|
| # We set LD_BIND_NOW to increase the efficiency of kdeinit.

Greetings,
Armmin
[prev in list] [next in list] [prev in thread] [next in thread]