[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KConfigIniBackend::stringToPrintable optimization patch
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2009-05-28 11:02:37
Message-ID: 20090528110237.GA1695 () troll08 ! nokia ! trolltech ! de
[Download RAW message or body]

hi,

On Thu, May 28, 2009 at 09:50:57AM +0700, Vyacheslav Tokarev wrote:
> 	Please review it, and if it's ok can I commit?
> 
> +    char* data = result.data();
> +    char* start = data;
>  
please use
   char *variable = ...

looks rather committable other than that. :-)
[prev in list] [next in list] [prev in thread] [next in thread]