[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Upgrade TerminalInterface to V2 and add two more
From:       "Rahman Duran" <rahman.duran () gmail ! com>
Date:       2009-03-31 10:30:17
Message-ID: 20090331103017.5530.11825 () localhost
[Download RAW message or body]



> On 2009-03-30 12:24:51, Trever Fischer wrote:
> > Just as a note, this patch breaks Yakuake on this line:
> > 
> >         m_terminalInterface = qobject_cast<TerminalInterfaceV2*>(m_part);

Did you also compiled the updated konsolePart? 


- Rahman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/444/#review740
-----------------------------------------------------------


On 2009-03-28 15:58:08, Rahman Duran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/444/
> -----------------------------------------------------------
> 
> (Updated 2009-03-28 15:58:08)
> 
> 
> Review request for kdelibs and Konsole.
> 
> 
> Summary
> -------
> 
> This is a new interface that extends the old ones functionality. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/interfaces/terminal/CMakeLists.txt 945618 
>   trunk/KDE/kdelibs/interfaces/terminal/kde_terminal_interface_v2.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/444/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahman
> 
>


[prev in list] [next in list] [prev in thread] [next in thread]