[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Strip duplicated path separators in KUrlNavigator
From:       "Peter Penz" <peter.penz () gmx ! at>
Date:       2009-03-30 6:45:44
Message-ID: 20090330064544.27618.85460 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/470/#review709
-----------------------------------------------------------


Looks good, but hopefully David Faure could have a quick look at the patch before \
shipping it.

- Peter


On 2009-03-29 16:09:31, Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/470/
> -----------------------------------------------------------
> 
> (Updated 2009-03-29 16:09:31)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Summary
> -------
> 
> This fixes bug 188417: when passing a path with duplicated separators (such as \
> "/tmp//foo" or "/tmp//foo//bar") to KUrlNavigator, the breadcrumb is not displayed \
> correctly (it only shows directories prior to the first duplicated separator -- in \
> this case, '/' and 'tmp'). 
> I just don't know if there are problems regarding creating a non-const KUrl url \
> from const KUrl& newUrl in KUrlNavigator::setUrl. 
> 
> This addresses bug 188417.
> https://bugs.kde.org/show_bug.cgi?id=188417
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 945690 
> 
> Diff: http://reviewboard.kde.org/r/470/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Raphael
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]