[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Use a custom property to define which property to for
From:       "Michael Leupold" <lemma () confuego ! org>
Date:       2009-03-27 19:51:57
Message-ID: 20090327195157.25468.59466 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/442/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

When using KConfigDialog you're currently restricted to one property (USER) per \
widget. Deviating from that on a per-widget basis is not possible - the only thing \
you can do is add the property to use to KConfigDialogManager's static propertymap \
affecting all widgets of that class alike. Alternatively you could subclass the \
widget.

This patch makes it possible to define the "kcfg_property" property on a widget which \
is queried by KConfigDialogManager before resorting to propertymap and USER. It's \
convenient because it can be set using designer.

One possible use case (and why I came up with this) is KUrlRequester:
It is basically meant for input of a URL but it can be used for URL-or-anything-else \
as well. Using KConfigXT's Url type is not an option for those "anything-else" values \
(eg. an application with variables for commandline arguments like "/usr/bin/kwrite \
%u").

I contemplated implementing the same for the changed signals but think this is out of \
scope. After all the use-case is getting different representations of the data within \
a widget which is still considered to only have one "value".


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/dialogs/kconfigdialogmanager.h 945602 
  /trunk/KDE/kdelibs/kdeui/dialogs/kconfigdialogmanager.cpp 945602 

Diff: http://reviewboard.kde.org/r/442/diff


Testing
-------


Thanks,

Michael


[prev in list] [next in list] [prev in thread] [next in thread]