[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Fwd: KFileDialog combined keyword/filename suggestion
From:       David Faure <faure () kde ! org>
Date:       2009-03-18 23:29:22
Message-ID: 200903190029.22722.faure () kde ! org
[Download RAW message or body]

On Friday 13 March 2009, Jonathan Marten wrote:
> David Faure <faure@kde.org> writes:
> > On Wednesday 11 March 2009, Jonathan Marten wrote:
> >> Albert Astals Cid <aacid@kde.org> writes:
> >> > You forgot to attach the patch :D
> >> 
> >> It's attached to the bug report
> >> (https://bugs.kde.org/show_bug.cgi?id=186230).  Follows here too...
> >
> > No objections from me. (Can't be 100% sure that there are no regressions, of course,
> > I don't know that code enough).
> 
> Thanks David for your comments.  OK to commit with your suggestions
> implemented? - I've run through the test cases and will do so again
> with these changes, and since this will only go into trunk any obscure
> regressions will not affect the stable branch.

Go ahead.

-- 
David Faure, faure@kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]