[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KFilterDev changes from KDE3
From:       Martin Koller <kollix () aon ! at>
Date:       2009-03-17 20:31:53
Message-ID: 200903172131.57095.kollix () aon ! at
[Download RAW message or body]


On Tuesday 17 March 2009, David Faure wrote:

> > Well, I know the mimetype, but as I do a backup of a _lot_ of files,
> > isn't the overhead too high to again and again calling findFilterByMimeType() 
> > (as the mimetype will never change during the complete backup) ?
> 
> KFilterBase::findFilterByMimeType only loads a mimetype from ksycoca
> (that's supposed to be really fast, just a dict lookup and a bit of deserialization)
> and compares strings. If it really turns out to be a bottleneck, we could add
> a cache in KFilterDev so that it remembers the last requested mimetype
> and the KFilterBase that was created for it (with care not to leak or double-delete
> kfilterbases...). In any case this can and should be handled internally in KFilterDev.

I now run a first test:

~18000 files processed: KDE4 3:02 Minutes, KDE3 2:12 Minutes ...

It _is_ a bottleneck, as this was just a small test.

-- 
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail 
          /\                        - against microsoft attachments

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]