[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Remove double & in KTabWidget
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2009-03-16 19:38:22
Message-ID: 200903162038.24323.aacid () kde ! org
[Download RAW message or body]

A Dissabte, 14 de març de 2009, Albert Astals Cid va escriure:
> As you can see in ktabwidgettest after r939151 we are adding double && to
> it that causes accelerators not to work.
>
> The culprit line is
>   title.replace( '&', "&&" );
> in
>   KTabWidget::Private::updateTab
>
> Removing it, the test (and kturtle that is what pointed me) work.
>
> Tobias, blame says that line is yours, do you remember why you added it?

Tobias said blame is not really his but from an earlier revision and from 
Riddell, he's agreed to remove the line so i've commited it.

Albert

>
> Ok, to remove it?
>
> Albert



[prev in list] [next in list] [prev in thread] [next in thread]