Many thanks Albert for checking the patch. I'll implement your suggestions and then update it. Albert Astals Cid writes: > kDebug() needs to be removed or get the proper area (kfile_area) Will update this. I'd looked for the definition of kfile_area in this file but couldn't find it, and guessed that it was obsolete (all of the debug statements using it are commented out). Now have found it (=250 in config-kfile.h). > New getStartUrl needs @since KDE 4.3 Spotted that when checking the apidox policy, have already added this to my local copy. > You need to provide proper API update for kfiledialog.h too (maybe it would be > a good idea just removing it from kfiledialog.h and put a link to kfilewidget > docu?) > > Also it would be good if you could update kio/kfile/tests/kfiledialogtest.cpp > with some tests covering all the new cases. I'll do both of these. Thanks and regards, Jonathan -- Jonathan Marten http://www.keelhaul.demon.co.uk Twickenham, UK jjm2@keelhaul.demon.co.uk